Fix require_full_match
#485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mitsuhiko#401 as well as most (but not all) of mitsuhiko#477
This fixes the issues in mitsuhiko#477, stacked on mitsuhiko#483. It's possible I've still missed something -- I realize that there are plenty of areas I'm still unsure about in the repo. Possibly some slower integration tests with sample projects would be worthwhile; though they don't make for the nimblest of tests...
|
Can you fix clippy here? |
|
#481 fixes clippy — can we merge that first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues in #477, stacked on #483.
It's possible I've still missed something (though the excellent repro in #477 passes). I realize that there are plenty of areas I'm still unsure about in the repo... Possibly some slower integration tests with sample projects would be worthwhile; though they don't make for the nimblest of tests...